Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] support python 3.13 #1093

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 8, 2024

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (eb2f926) to head (88fb314).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1093   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          63       63           
  Lines        7141     7141           
  Branches     1367     1367           
=======================================
  Hits         6411     6411           
  Misses        531      531           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 8, 2024

failure looks like an upstream error, no?

   bids/modeling/report/viz.py:1: in <module>
      import altair as alt
  .tox/py313-full/lib/python3.13/site-packages/altair/__init__.py:650: in <module>
      from altair.vegalite import *
  .tox/py313-full/lib/python3.13/site-packages/altair/vegalite/__init__.py:2: in <module>
      from .v5 import *
  .tox/py313-full/lib/python3.13/site-packages/altair/vegalite/v5/__init__.py:4: in <module>
      from .api import *
  .tox/py313-full/lib/python3.13/site-packages/altair/vegalite/v5/api.py:618: in <module>
      class _ConditionClosed(TypedDict, closed=True, total=False):  # type: ignore[call-arg]
  E   TypeError: _TypedDictMeta.__new__() got an unexpected keyword argument 'closed'

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant